refactor: move hooks under own directory #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikitaCG
requested review from
amje,
korvin89,
kseniya57,
jhoncool,
Raubzeug,
Lunory and
ValeraS
as code owners
|
Preview is ready. |
korvin89
approved these changes
Oct 6, 2023
ogonkov
approved these changes
Oct 6, 2023
| ...refs: Array<React.Ref<T> | undefined> | ||
| ): React.RefCallback<T> | null { | ||
| export type UseForkRefProps<K> = Array<React.Ref<K> | undefined>; | ||
| export type UseForkRefResult<W> = React.RefCallback<W> | null; |
Lunory
approved these changes
Oct 9, 2023
jhoncool
approved these changes
Oct 10, 2023
Raubzeug
approved these changes
Oct 10, 2023
amje
requested changes
Oct 10, 2023
| @@ -16,18 +16,20 @@ export type UseFileInputOutput = { | |||
| }; | |||
| }; | |||
|
|
|||
| export type UseFileInputResult = UseFileInputOutput; | |||
There was a problem hiding this comment.
Let's mark old type with deprecation note
src/hooks/useUniqId/README.md
Outdated
| import {useUniqId} from '@gravity-ui/uikit'; | ||
| ``` | ||
|
|
||
| The `useUniqId` hook create uniq Id. |
src/hooks/useUniqId/README.md
Outdated
|
|
||
| ## Result | ||
|
|
||
| Id. `string` |
src/hooks/useForkRef/README.md
Outdated
| import {useForkRef} from '@gravity-ui/uikit'; | ||
| ``` | ||
|
|
||
| The `useForkRef` hook that can combine refs into a single Ref |
amje
approved these changes
Oct 10, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also moved
constants.tsin right folder